[FFM-5387]: Fix Golang Group Rule Evaluate and Add Tests #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story FFM-5387 · Convert ff test grid features to SDK test features |
|
Looks great! As a sanity check for you I checked out your forked copy and ran the tests, all 219 passed. |
erdirowlands
approved these changes
Nov 18, 2022
davejohnston
force-pushed
the
FFM-5387
branch
from
39671d3
to
115afce
Compare
Run evalutor tests against the ff-test-grid test-cases Improve test coverage
Fix the group rule evaluator. Currently rules are being AND'd but they should be OR'd
davejohnston
force-pushed
the
FFM-5387
branch
from
115afce
to
ffbd02e
Compare
davejohnston
changed the title
davejohnston
added a commit
to davejohnston/ff-golang-server-sdk
that referenced
this pull request
Sep 26, 2023
Run evaluator tests against the ff-test-grid test-cases Improve test coverage Fix the group rule evaluator. Currently rules are being AND'd but they should be OR'd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run evaluator tests against the ff-test-grid test-cases
Fix the group rule evaluator which was AND'ing instead of OR'ing the rules
Why
Improve test coverage and fix an evaluator bug