[FFM-5510]: Fixing the condition in evaluator to consider empty slice + expose Evaluate function #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akiraqb
commented
Nov 24, 2022
•
akiraqb
commented
akiraqb
changed the title
davejohnston
pushed a commit
to davejohnston/ff-golang-server-sdk
that referenced
this pull request
Sep 26, 2023
… + expose Evaluate function (harness#104) [FFM-5510]: Fixing the condition in evaluator to consider empty slice + Exposing Evaluate function # What: Small fix to consider empty slice in the condition for clause evaluation # Why: Previously segment.rules would either be nil pointer or pointer to slice with at least one element. Due to changes made for FFM-4150 we require extra check. # Testing: Locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.