FFM-8067 Call onStreamError anytime we exit Subscribe #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Makes sure we call `onStreamError` anytime we break out of the SubscribeWithContext function - If an eventListener has been passed to the Proxy we call its `Pub` method with an error. This lets the eventListener know that the stream its listening to has disconnected **Why** - Currently we only call `onStreamError` if SubscribeWithContext returns an error. However if the stream is intentionally closed by the server rather than bubbling up the EOF error the SSE library we're using swallows it. This means we never call `onStreamError` which means the SDK thinks it's still connected to the stream and receiving SSE events which means it stops getting any changes because it isn't operating in polling mode and won't get any SSE events. Calling `onStreamError` means we'll set `streamConnected=false` and the SDK will poll for changes until it can reconnect to the stream - For the eventListner code we can use this in the ff-proxy to pass on disconnects between the Proxy & ff-server to SDKs connected to the Proxy **Testing** I've been testing this out locally by getting the Proxy to close the stream with the SDK if it disconnects from ff-server
|
✅ Linked to FFM-8067 · Go SDK - When SSE stream is closed set streamDisconnected=true |
andybharness
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
onStreamErroranytime we break out of the SubscribeWithContext functionPubmethod with an error. This lets the eventListener know that the stream its listening to has disconnectedWhy
onStreamErrorif SubscribeWithContext returns an error. However if the stream is intentionally closed by the server rather than bubbling up the EOF error the SSE library we're using swallows it. This means we never callonStreamErrorwhich means the SDK thinks it's still connected to the stream and receiving SSE events which means it stops getting any changes because it isn't operating in polling mode and won't get any SSE events. CallingonStreamErrormeans we'll setstreamConnected=falseand the SDK will poll for changes until it can reconnect to the streamTesting
I've been testing this out locally by getting the Proxy to close the stream with the SDK if it disconnects from ff-server