FFM-9314 Refresh cache if FeatureConfigs are outdated #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcox250
changed the title
pkg/repository/repository.go
Outdated
| if ok && cacheable { | ||
| r.cache.Set(flagKey, flag) | ||
| } | ||
| return flag.([]rest.FeatureConfig), nil |
There was a problem hiding this comment.
should we move this return statement inside the ok block? So if we fail to get from storage, and weve already failked to get from the cache, we error?
There was a problem hiding this comment.
Yea I think that makes sense
davejohnston
approved these changes
Sep 12, 2023
**What** - Changes conditon so we only break out of SetFlags if the flags ARE NOT outdated **Why** - If the flags are outdated we want to carry on inside SetFlags and refresh the cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What