[FFM-1251]: Rules for flags added directly to segment not working #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: Append segments from the target segment variation map, to the list of segments that should be loaded by a feature config. Why: There are two ways to add a segment to a flag. 1) From segments added through flag rules 2) From segments in the variation target map. The first use-case worked, because we parse the rules and create a list of segments to load from the cache, prior to evaluating rules. The second use-case did not work, as we didn't append segments from the variation target map in the list.
enver-bisevac
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Append segments from the target segment variation map, to the list of segments
that should be loaded by a feature config.
Why:
There are two ways to add a segment to a flag.
The first use-case worked, because we parse the rules and create a list of segments to load
from the cache, prior to evaluating rules.
The second use-case did not work, as we didn't append segments from the variation target map
in the list.