[FFM-2217]: Evaluation returning wrong result with multiple segments #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oups Segments evaluation had two problems: 1) It returned false if any segment evaluate returned false (even if segment was not part of the clause) 2) It evaluated the target in segmentMatch clause against all segments, where it should only evaluate against the segments defined by the clause. Evaluation Percentage Rollout was also distributing values incorrectly when there were more than two variations. Updated unit tests to ensure segment Evaluation performed as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Segments evaluation had two problems:
the segments defined by the clause.
Evaluation Percentage Rollout was also distributing values incorrectly when there were more than
two variations.
Testing
Updated unit tests to ensure segment Evaluation performed as expected