FFM-2514 add function to convert various types to string #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Hayes
reviewed
Apr 7, 2022
| input interface{} | ||
| expected string | ||
| }{ | ||
| "Given I input a string": { |
There was a problem hiding this comment.
should we add some nils? check it handles it ok?
There was a problem hiding this comment.
Will add a test for nils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tightens up string conversion around attribute values when we're posting metrics.
Why
Previously if you provided an int value for an attribute then it was being sent to the metrics service as an empty string
Testing
Made my golang-server-sample use this branch of the SDK and I could see that integer attributes values were now being received by the metrics service on my local ff-server