FFM-2934 Bugfix - compare custom attributes based on string values #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reflect.Invalid, reflect.Ptr, reflect.Slice, reflect.Struct, reflect.Uintptr, reflect.UnsafePointer, | ||
| reflect.Float32, reflect.Float64, reflect.Int16, reflect.Int32, reflect.Int8, reflect.Map, reflect.Uint, | ||
| reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uint8: | ||
| object = fmt.Sprintf("%v", object) |
There was a problem hiding this comment.
this will be slower than conv, Sprintf accept interface and it will do one pass more, right?
There was a problem hiding this comment.
Yea it will but in the interest of not having to write a specific conversion case for all these unexpected types I just defaulted to using fmt.Sprintf. The only reason this case is actually really in here instead of letting them all fallthrough to the default was to please the linter.
enver-bisevac
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out
attrValue.String()will not return a string value ifattrValueis an int, boolean or any other non string type. So I've made a change to check theKindofattrValueand then do the appropriate conversion for that kind to a string.