FFM-3703 - Go FF SDK Broken by Kin API Changes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug FFM-3703 · Go FF SDK Broken by Kin API Changes |
| github.com/getkin/kin-openapi v0.53.0 | ||
| github.com/golang-jwt/jwt v3.2.1+incompatible | ||
| github.com/google/uuid v1.2.0 | ||
| github.com/deepmap/oapi-codegen v1.11.0 |
There was a problem hiding this comment.
I think we should be careful when increasing dep versions, this module is used with ff-server so probably it will need some sanity check
jcox250
reviewed
Jun 23, 2022
evaluation/evaluator.go
Outdated
| @@ -200,7 +200,7 @@ func (e Evaluator) evaluateVariationMap(variationsMap []rest.VariationMap, targe | |||
|
|
|||
| func (e Evaluator) evaluateFlag(fc rest.FeatureConfig, target *Target) (rest.Variation, error) { | |||
| var variation = fc.OffVariation | |||
| if fc.State == rest.FeatureState_on { | |||
| if fc.State == rest.On { | |||
There was a problem hiding this comment.
Is this changing from FeatureState_on to On something that we can control?
There was a problem hiding this comment.
Yeah i've just ran some backwards compatibility stuff i've found and been able to revert this
jcox250
reviewed
Jun 23, 2022
…change, update tests, code where needed to respect new version gen code
stephenmcconkey
force-pushed
the
FFM-3703
branch
from
13c00da
to
ab33da4
Compare
conormurray95
approved these changes
Jun 24, 2022
davejohnston
pushed a commit
to davejohnston/ff-golang-server-sdk
that referenced
this pull request
Sep 26, 2023
* Update Kin and OpenAPI versions, add yaml config for openAPI version change, update tests, code where needed to respect new version gen code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update Kin and OpenAPI versions
Update makefile to conform to new call style
Add yaml config for openAPI version change
Update tests, code where needed to respect new version gen code
Used this to generate the config files
oapi-codegen --output-config --old-config-style --package=<package-name> --generate="types" -alias-types <output>.yamlAs per - https://github.com/deepmap/oapi-codegen/releases
FFM-3703
Why
The Go FF SDK is unusable on new projects without hacking Go.mod/go.sum as the Kin project has published a non-semver friendly version.
Testing
Unit tests update where appropriate with small changes in gen code
Manual testing to use this version of sdk to poll featureflags - working with no compilation errors