FFM-4043 - Add checks for nested pre req flags #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcox250
approved these changes
Jul 28, 2022
|
Spoke with Dave, we will deal with the recursive stuff as part of the performance work |
davejohnston
pushed a commit
to davejohnston/ff-golang-server-sdk
that referenced
this pull request
Sep 26, 2023
* Change 'number' to 'int' input on number variations * Check prereq flags for nested prereqs, update example app * simple refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a recursive check to check that pre requisite flags with pre requisite flags are honoured
Slight update to example to fulfil docs changes
Why
Flags that had nested pre requisites were only being evaluated against the initial pre requisite
Testing
Unit Tests
Manual Testing
-- aware that the branching looks out of date, but need to make a tag for 0.0. and for 0.1.