Ffm 3677 #96
Merged
Ffm 3677 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug FFM-3677 · Golang SDK doesn't have option to turn analytics off |
jcox250
reviewed
Jul 27, 2022
client/client.go
Outdated
| c.mux.RLock() | ||
| defer c.mux.RUnlock() | ||
| if !c.config.enableAnalytics { | ||
| log.Println(time.Now().Format("2006-01-02 15:04:05") + " Posting analytics data disabled.") |
There was a problem hiding this comment.
I think for consistency we should use the c.config.Logger that gets used elsewhere in this client code for here and the line below. I think it logs out timestamp info for us as well so all you'll need to do is include the message https://github.com/harness/ff-golang-server-sdk/pull/96/files#diff-bd3a55a72186f59e2e63efb4951573b2f9e4a7cc98086e922b0859f8ccc1dd09L387
jcox250
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review changes.
Since the thread is not starting I don't think there will be anything cached.