Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffm 3677 #96

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Ffm 3677 #96

merged 4 commits into from
Jul 28, 2022

Conversation

akiraqb
Copy link
Contributor

@akiraqb akiraqb commented Jul 27, 2022

Please review changes.
Since the thread is not starting I don't think there will be anything cached.

@akiraqb akiraqb requested a review from jcox250 July 27, 2022 09:13
@swarmia
Copy link

swarmia bot commented Jul 27, 2022

client/client.go Outdated
c.mux.RLock()
defer c.mux.RUnlock()
if !c.config.enableAnalytics {
log.Println(time.Now().Format("2006-01-02 15:04:05") + " Posting analytics data disabled.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for consistency we should use the c.config.Logger that gets used elsewhere in this client code for here and the line below. I think it logs out timestamp info for us as well so all you'll need to do is include the message https://github.com/harness/ff-golang-server-sdk/pull/96/files#diff-bd3a55a72186f59e2e63efb4951573b2f9e4a7cc98086e922b0859f8ccc1dd09L387

@akiraqb akiraqb merged commit ad5712c into main Jul 28, 2022
@erdirowlands erdirowlands deleted the FFM-3677 branch November 3, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants