Fix incorrect position of Add Comment button in PR Review under Safari (

#672)
harness · Oct 11, 2023 · 5683e43 · 5683e43
1 parent 23b9117
commit 5683e43
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/web/src/components/DiffViewer/DiffViewer.module.scss b/web/src/components/DiffViewer/DiffViewer.module.scss
@@ -77,6 +77,10 @@
         }
       }
 
+      .d2h-code-side-line {
+        position: relative;
+      }
+
       [data-content-for-line-number] {
         cursor: default;
 

diff --git a/web/src/components/DiffViewer/DiffViewerUtils.tsx b/web/src/components/DiffViewer/DiffViewerUtils.tsx
@@ -86,19 +86,19 @@ export const DIFF2HTML_CONFIG = {
           {{{lineNumber}}} {{{filePath}}}
         </td>
         <td class="{{type}}" data-content-for-line-number="{{lineNumber}}" data-content-for-file-path="{{file.filePath}}">
-            <div data-annotation-for-line="{{lineNumber}}" tab-index="0" role="button">+</div>
             <div class="{{contentClass}}">
+              <span data-annotation-for-line="{{lineNumber}}" tab-index="0" role="button">+</span>
             {{#prefix}}
-                <span class="d2h-code-line-prefix">{{{prefix}}}</span>
+              <span class="d2h-code-line-prefix">{{{prefix}}}</span>
             {{/prefix}}
             {{^prefix}}
-                <span class="d2h-code-line-prefix">&nbsp;</span>
+              <span class="d2h-code-line-prefix">&nbsp;</span>
             {{/prefix}}
             {{#content}}
-                <span class="d2h-code-line-ctn">{{{content}}}</span>
+              <span class="d2h-code-line-ctn">{{{content}}}</span>
             {{/content}}
             {{^content}}
-                <span class="d2h-code-line-ctn"><br></span>
+              <span class="d2h-code-line-ctn"><br></span>
             {{/content}}
             </div>
         </td>