Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea pull request handling is inconsistent #2314

Closed
xoxys opened this issue Jan 24, 2018 · 9 comments
Closed

Gitea pull request handling is inconsistent #2314

xoxys opened this issue Jan 24, 2018 · 9 comments

Comments

@xoxys
Copy link

xoxys commented Jan 24, 2018

If a pull request is not closed and a change was commited to the referending branch the commit will be appended to the existing pull request. But the drone status for this commit does not exist in the pr:

Forked repo:
grafik

Pull request:
grafik

Also drone does not run again if a opened pull request was updated with another commit. Is it possible to re-run drone if there was a new commit to a pull request (pull request updated)?

@tboerger
Copy link

If drone receives a webhook it will start another build.

@xoxys
Copy link
Author

xoxys commented Jan 25, 2018

@tboerger How does this solve my described problem?

@pylanglois
Copy link

pylanglois commented Jan 25, 2018

I have the same problem with gitea/drone

It seems that gitea does not have all the webhooks implemented (go-gitea/gitea#2418). Maybe this is a part of the problem.

Gitea does not display the PR state correctly. Only the first commit carries the state from the drone build. It is misleading because drone will build all the pull request, not the specific commit "54acdb3536" in your case. Every PR rebuild will update the state of the first commit in gitea. As a workaround, you can go in drone web interface and manually rebuild the pull request, it will rebuild all commit related to that PR.

The state of the build should be seen in the PR title, not on the "first commit" since each commit as a different state. Probably a gitea issue...

@xoxys
Copy link
Author

xoxys commented Jan 29, 2018

Any chance to get this fixed?

@bradrydzewski
Copy link

This is not on my current priority list, so I would recommend sending a pull request if you would like to see this resolved in a timely matter.

@tboerger
Copy link

/cc @appleboy @lunny

@xoxys
Copy link
Author

xoxys commented Jan 29, 2018

@tboerger Thanks for pointing this to gitea

@xoxys
Copy link
Author

xoxys commented Jan 29, 2018

@bradrydzewski Thanks for your reply. I'm not a developer so for me its hard to address this issue

@bradrydzewski
Copy link

fixed in 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants