Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new metrics] drone_http_response_code_[2/3/4/5]xx #2421

Open
tonglil opened this issue May 24, 2018 · 3 comments
Open

[new metrics] drone_http_response_code_[2/3/4/5]xx #2421

tonglil opened this issue May 24, 2018 · 3 comments
Milestone
v1.7.0

Comments

@tonglil
Copy link

tonglil commented May 24, 2018

drone_http_response_code_2xx

Type: counter

Purpose: tracks response code segments

Labels:

  • endpoint
  • specific code (200|etc)

drone_http_response_code_3xx

Type: counter

Purpose: tracks response code segments

Labels:

  • endpoint
  • specific code (304|etc)

drone_http_response_code_4xx

Type: counter

Purpose: tracks response code segments

Labels:

  • endpoint
  • specific code (401|404|etc)

drone_http_response_code_5xx

Type: counter

Purpose: tracks response code segments

Labels:

  • endpoint
  • specific code (500|502|etc)
@bradrydzewski
Copy link

Thoughts on how we want to handle 403 Forbidden, which may indicate Not Found (valid error) or may just indicate the user needs to login (false positive)? Similarly how we want to handle requests to /api/user when a guest visits the website, and we expect this endpoint to fail? I would like to eliminate these false positives from the overall metrics.

@bradrydzewski bradrydzewski added this to the v1.x.x milestone Apr 19, 2019
@bradrydzewski bradrydzewski removed this from the v1.x.x milestone Sep 17, 2019
@bradrydzewski
Copy link

reference code for custom chi middleware:
https://github.com/766b/chi-prometheus/blob/master/middleware.go

@bradrydzewski bradrydzewski added this to the v1.7.0 milestone Oct 4, 2019
@lukepatrick
Copy link

+1 - great feature request

@maxknee maxknee mentioned this issue Nov 30, 2023
Merged
tphoney pushed a commit that referenced this issue Jan 2, 2024
@maxknee
add http prometheus metrics (#3432)
3c37646 
This will add metrics to http endpoints to measure latency and to see if
other parts of infra are working

This will close #2421

Signed-off-by: Max Knee <max.knee@nytimes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
3 participants
@bradrydzewski @lukepatrick @tonglil