Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add BitBucket repo in 0.3 #652

Closed
jloh opened this issue Nov 1, 2014 · 11 comments
Closed

Cannot add BitBucket repo in 0.3 #652

jloh opened this issue Nov 1, 2014 · 11 comments

Comments

@jloh
Copy link

jloh commented Nov 1, 2014

For some reason I can't add a BitBucket repo at all in 0.3. It pulls my repos fine and syncs them locally, but it doesn't actually add any hooks on BitBuckets side.

When I click activate the spinning wheel runs, then disappears and no errors get printed out to /var/log/upstart/drone.log but I do get a 500 error upon adding it in the developer console.

POST https://drone.mooash.com/api/repos/bitbucket.org/Mooash/Testing 500 (Internal Server Error) angular.js:7991
(anonymous function) angular.js:7991
C angular.js:7813f angular.js:7547
C angular.js:10943
C angular.js:10943
(anonymous function) angular.js:11029
h.$eval angular.js:11949
h.$digest angular.js:11775
h.$apply angular.js:12055
(anonymous function) angular.js:17833
(anonymous function) angular.js:2612
q angular.js:309
Zc.c angular.js:2611

At first I thought it was due to my repo being called something with spaces so %20 characters get printed in the URL.

@jloh
Copy link
Author

jloh commented Nov 1, 2014

Also worth noting that it doesn't appear to be creating any hooks or anything on the BitBucket side.

@bradrydzewski
Copy link

do you have admin access to the repo in Bitbucket? Perhaps this is a duplicate of #542?

@bradrydzewski
Copy link

I just tested the latest version of master and was able to add hooks and keys. I tested with both a public and private repository.

I was able to repeat the issue when trying to activate a repository that my bitbucket user account did not have admin access to. I think this can be merged with #542 and we can do a better job of surfacing the relevant error message.

@jloh
Copy link
Author

jloh commented Nov 2, 2014

@bradrydzewski I've just managed to repeat this by creating two repos with the same name except one had a capital, ie one repo was called drone and another was called Drone.

drone added fine, Drone had the symptoms I've described above.

@jloh
Copy link
Author

jloh commented Nov 6, 2014

@bradrydzewski any chance of getting this reopened since I can repeat the behaviour?

@bradrydzewski
Copy link

@MooASh I think this is a problem at the database level. For example:
http://dev.mysql.com/doc/refman/5.0/en/case-sensitivity.html

The default character set and collation are latin1 and latin1_swedish_ci, so nonbinary string comparisons are case insensitive by default. This means that if you search with col_name LIKE 'a%', you get all column values that start with A or a.

@jloh
Copy link
Author

jloh commented Nov 6, 2014

@bradrydzewski I'm not using a database, just the default sqlite DB.

@bradrydzewski
Copy link

this is the same behavior in SQLite:
http://www.sqlite.org/faq.html#q18

The default configuration of SQLite only supports case-insensitive comparisons of ASCII characters. The reason for this is that doing full Unicode case-insensitive comparisons and case conversions requires tables and logic that would nearly double the size of the SQLite library. The SQLite developers reason that any application that needs full Unicode case support probably already has the necessary tables and functions and so SQLite should not take up space to duplicate this ability.

@jloh
Copy link
Author

jloh commented Nov 6, 2014

So you're saying that I can't have capital letters in the BitBucket repos?

@itomaldonado
Copy link

I had the same issue, changed the BitBucket repo name to all lower case and solved the issue. Maybe there should be some comparison done at the app level instead of the DB level...

@rafaelbeckel
Copy link

Same issue here. Changing repo to lowercase didn't solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants