-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Dockerfile to make drone run inside a container #14
Conversation
awesome! some minor suggestions we should add
let's use
you mentioned this was just the beginning, so I didn't know if you wanted to make the changes, or you wanted me to merge this PR and I can make them myself. Either way, thanks! |
Thanks i'll make the changes |
By the way, if it means anything, I've taken your PR and merged in these changes requested from @bradrydzewski and I get the following:
It seems that we're not installing everything we need or I've just done something wrong somehow. If I find out what is up before you do, I'll post it here. |
sigh...found it, somehow blew away the "make deps". |
@whitlockjc Feel free to take over and open a new PR with the changes if I don't get to it in time. Not going to hurt my feelings ;) |
I can be patient, no rush on my end. I have been playing with it and I have it working but I did run into an interesting constraint. Using boot2docker (OS X), I run into memory issues when building go due to the tests. It seems to be a known issue. Since it's known to be a problem and we're treating Go as an external dependency, maybe using |
Yes, change it to |
you could also download the pre-compiled Go binaries:
and add these env variables
|
Would you rather binaries or source build? I have it working now, although I did run into some OS X specific stuff with VirtualBox and port forwarding port 80. |
@whitlockjc I think the binaries would be fine |
Here is my current version:
This works and it includes the changes mentioned above, although it still builds go 1.2 from source instead of using a binary. On OS X, you have to use port forwarding when you run the container to work around the inability of VirtualBox.app to forward ports less than 1024 like this |
@whitlockjc I would add |
Done. A quick question: Why would Docker fail to run drone when drone is listening on port 80 but it runs fine with the default port 8080? When I say "fail to run", when I run the container configured to connect on port 80 and port forward 80->8080 on the host, I get no data back. If I run the same container but tell drone to listen on port 8080 instead of 80 and then port forward 8080->8080 on the host, I get the page back. I'm on OS X so this could be a boot2docker on OS X ism. Here is the current iteration:
|
Closing so @whitlockjc can take this over, sorry i don't have time right now |
…, but log and return. Also adds some more validations for path creation and resource moving. Add accesslogging for git and api router (#14) This commit contains the following: - Improve and simplify error handling (remove unnecessary wrappers, make it feel like go) - Add extra validation for path creation and resource moving (path has to be within same top space, no top space alias allowed) - Add access logging for rest api and git api
This is just the beginning to get drone running inside a container and talking to a local or remote docker.