Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OAuth2 token refresher for Gitlab #3215

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

EndymionWight
Copy link

Fixes the bug (reported here) introduced by recent changes to Gitlab token expiration. Blatant copy-paste of Gitea implementation (please feel free to improve if problematic), but tested and working on our local Drone deployment.

@CLAassistant
Copy link

CLAassistant commented May 19, 2022

CLA assistant check
All committers have signed the CLA.

@mehran-prs
Copy link

mehran-prs commented May 27, 2022

@tphoney any update on this bug?
Gitlab users can not use Drone until fixing the token expiration bug!

@mentalrob
Copy link

We are facing the issue still, any updates on this ?

@zarlo
Copy link

zarlo commented Jun 6, 2022

any update?

@Kishi85
Copy link

Kishi85 commented Jun 13, 2022

Is there any reason why this has not been merged yet ? Any Gitlab >=15.0.0 is pretty much broken without this. Since it's just refreshing the token older Gitlab Versions should not have any Problems as far as i can see.

@eoinmcafee00 eoinmcafee00 merged commit b605339 into harness:master Jun 14, 2022
ivanvc pushed a commit to ivanvc/drone that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants