Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: increase the max length of the secret (#3493) #3494

Merged
merged 4 commits into from Apr 19, 2024

Conversation

rambhosale
Copy link
Contributor

This PR increases the default maxlength from 1024 characters to 10000, which should be good for most cases.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ram Bhosale seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@xzycn
Copy link

xzycn commented Apr 19, 2024

Hi, there is any progress on this? This is very important issue.
We are painful to store k8s cert.

@tan-nhu tan-nhu merged commit 2d96ca5 into harness:main Apr 19, 2024
1 of 2 checks passed
@tan-nhu
Copy link
Contributor

tan-nhu commented Apr 19, 2024

There's still an error with prettier. I merged anyway. I'm fixing the issue from our end. Thanks @rambhosale, @xzycn for the contribution.

@xzycn
Copy link

xzycn commented Apr 20, 2024

@tan-nhu
Hi, thx for your job.
May I ask when your next release will come? I have recently use gitness(v3.0.0-beta.6) as our CI/CD tools,there are some bugs or inconvenient design.
So I want a newer release including this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants