[PL-39802]: fix for showing PAT value in terraform resource (#605)

harness · Jul 4, 2023 · 52b6d1e · 52b6d1e
1 parent f7856bb
commit 52b6d1e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 13 deletions.
diff --git a/internal/service/platform/token/resource_token.go b/internal/service/platform/token/resource_token.go
@@ -118,6 +118,12 @@ func ResourceToken() *schema.Resource {
 				Optional:    true,
 				Elem:        &schema.Schema{Type: schema.TypeString},
 			},
+			"value": {
+				Description: "Value of the Token",
+				Type:        schema.TypeString,
+				Computed:    true,
+				Sensitive:   true,
+			},
 		},
 	}
 
@@ -156,13 +162,15 @@ func resourceTokenCreateOrUpdate(ctx context.Context, d *schema.ResourceData, me
 	var err error
 	var resp nextgen.ResponseDtoToken
 	var httpResp *http.Response
+	var createResponse nextgen.ResponseDtoString
 
 	id := d.Id()
 	token := buildToken(d)
 
 	if id == "" {
-		_, httpResp, err = c.TokenApi.CreateToken(ctx, c.AccountId, &nextgen.TokenApiCreateTokenOpts{Body: optional.NewInterface(token)})
+		createResponse, httpResp, err = c.TokenApi.CreateToken(ctx, c.AccountId, &nextgen.TokenApiCreateTokenOpts{Body: optional.NewInterface(token)})
 		if err == nil {
+			d.Set("value", createResponse.Data)
 			return resourceTokenRead(ctx, d, meta)
 		}
 	} else {

diff --git a/internal/service/platform/token/resource_token_test.go b/internal/service/platform/token/resource_token_test.go
@@ -44,10 +44,11 @@ func TestAccResourceToken(t *testing.T) {
 				),
 			},
 			{
-				ResourceName:      resourceName,
-				ImportState:       true,
-				ImportStateVerify: true,
-				ImportStateIdFunc: AccountResourceImportTokenIdFunc(resourceName),
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateIdFunc:       AccountResourceImportTokenIdFunc(resourceName),
+				ImportStateVerifyIgnore: []string{"value"},
 			},
 		},
 	})
@@ -85,10 +86,11 @@ func TestAccResourceTokenOrgLevel(t *testing.T) {
 				),
 			},
 			{
-				ResourceName:      resourceName,
-				ImportState:       true,
-				ImportStateVerify: true,
-				ImportStateIdFunc: OrgResourceImportTokenIdFunc(resourceName),
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateIdFunc:       OrgResourceImportTokenIdFunc(resourceName),
+				ImportStateVerifyIgnore: []string{"value"},
 			},
 		},
 	})
@@ -126,10 +128,11 @@ func TestAccResourceTokenProjectLevel(t *testing.T) {
 				),
 			},
 			{
-				ResourceName:      resourceName,
-				ImportState:       true,
-				ImportStateVerify: true,
-				ImportStateIdFunc: ProjectResourceImportTokenIdFunc(resourceName),
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateIdFunc:       ProjectResourceImportTokenIdFunc(resourceName),
+				ImportStateVerifyIgnore: []string{"value"},
 			},
 		},
 	})