[fix]: [SRM-16226]: Adding health source deseralizer (#777)

* [fix]: [SRM-16226]: add metric threshold * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr * [fix]: [SRM-16226]: Adding health source deseralizr
harness · Nov 28, 2023 · e3ee0b5 · e3ee0b5
1 parent 1c4921d
commit e3ee0b5
Show file tree

Hide file tree

Showing 5 changed files with 530 additions and 34 deletions.
diff --git a/.changelog/777.txt b/.changelog/777.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+Monitored service didn't use to honour metric threshold correctly earlier with this fix customer can add metric threshold to all the health sources
+```
diff --git a/internal/service/platform/monitored_service/data_source_monitored_service_test.go b/internal/service/platform/monitored_service/data_source_monitored_service_test.go
@@ -284,6 +284,22 @@ func testAccSumologicMetricDataSourceMonitoredService(id string, name string) st
                     liveMonitoringEnabled = "true"
                     continuousVerificationEnabled = "true"
                     sliEnabled = "false"
+					metricThresholds: [
+					{
+					  type: "IgnoreThreshold",
+					  spec: {
+						action: "Ignore"
+					  },
+					  criteria: {
+						type: "Absolute",
+						spec: {
+						  greaterThan: 100
+						}
+					  },
+					  metricType: "Custom",
+					  metricName: "sumologicmetrics"
+					}
+					]
 					},
 					{
 					name  = "name2"
@@ -793,6 +809,27 @@ resource "harness_platform_monitored_service" "test" {
             isManualQuery            = true
           }
         ]
+		metricPacks: [
+			{
+			  identifier: "Custom",
+			  metricThresholds: [
+				{
+				  type: "IgnoreThreshold",
+				  spec: {
+					action: "Ignore"
+				  },
+				  criteria: {
+					type: "Absolute",
+					spec: {
+					  greaterThan: 100
+					}
+				  },
+				  metricType: "Custom",
+				  metricName: "Prometheus Metric"
+				}
+			  ]
+			}
+		]
       })
     }
     template_ref  = "template_ref"
@@ -841,6 +878,27 @@ resource "harness_platform_monitored_service" "test" {
       spec = jsonencode({
         connectorRef = "connectorRef"
         feature = "Datadog Cloud Metrics"
+		metricPacks: [
+			{
+			  identifier: "Custom",
+			  metricThresholds: [
+				{
+				  type: "IgnoreThreshold",
+				  spec: {
+					action: "Ignore"
+				  },
+				  criteria: {
+					type: "Absolute",
+					spec: {
+					  greaterThan: 100
+					}
+				  },
+				  metricType: "Custom",
+				  metricName: "metric"
+				}
+			  ]
+			}
+		]
         metricDefinitions = [
           {
             metricName       = "metric"