Added default option to AWS secrets manager #633
Conversation
carsongee
force-pushed
the
carsongee/add_default_secret
branch
from
dfbb0a8
to
b786103
Compare
|
trigger build, subcategoryfieldcheck |
There was a problem hiding this comment.
@VikasMaddukuriHarness @tiwaritejas there are changes in schema and examples so that will require doc change, also add changelog file and add tests to test new changes
|
I have added to the existing test cases as well as an example to cover this new parameter. I'm happy to add additional test cases if this isn't sufficient. Additionally, I can try and update the auto-docs and schemas. I tried doing it locally, but it produced so many unrelated changes I decided it was better not to push them to be on the safe side. If you have guides or docs somewhere to update those, or you can give me instructions I'm happy to help move this forward. Thanks! |
VikasMaddukuriHarness
dismissed stale reviews from tiwaritejas and themself
via
0f8b01b
|
trigger build, subcategoryfieldcheck |
|
trigger build, subcategoryfieldcheck |
Describe your changes
The provider for AWS is missing the Default option from the UI:
Ulan Bekishov recommended I give it a shot to add it myself
Comment Triggers
PR Check triggers
trigger buildtrigger subcategoryfieldcheck