FFM-9085: Add a terraform resource to create a new target #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitk-h
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Please add unit tests for the resource. Ref https://harness.atlassian.net/wiki/spaces/PLATFORM/pages/21122646032/Terraform+Onboarding+and+Quickstart+for+Creating+Resource+in+Provider
ribeirophillipe
force-pushed
the
FFM-9085
branch
12 times, most recently
from
1bf692a
to
64ac107
Compare
|
@rohitk-h unit tests were added! |
rathodmeetsatish
requested changes
Aug 28, 2023
ribeirophillipe
force-pushed
the
FFM-9085
branch
from
64ac107
to
ff2444f
Compare
|
@rathodmeetsatish done |
rathodmeetsatish
requested changes
Aug 29, 2023
* Implement CRUD actions for creating a new target in terraform * Add all the interfaces and implementations * Add unit test * Fix package path * Add build script * Fix code base * Add release target * Include documentation and examples
ribeirophillipe
force-pushed
the
FFM-9085
branch
from
ff2444f
to
c321e76
Compare
rathodmeetsatish
requested changes
Aug 30, 2023
examples/data-sources/harness_platform_monitored_service/data-source.tf
Outdated
Show resolved
Hide resolved
rathodmeetsatish
requested changes
Aug 30, 2023
rathodmeetsatish
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Comment Triggers
PR Check triggers
trigger buildtrigger subcategoryfieldcheck