FFM-9086: Add a terraform resource to create a new target group #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirophillipe
force-pushed
the
FFM-9086
branch
8 times, most recently
from
d5b6b99
to
5285755
Compare
* Add resource feature_flag_target_group * Add unit tests * Update documents and release note
ribeirophillipe
force-pushed
the
FFM-9086
branch
from
f9c4efd
to
6760d1c
Compare
ribeirophillipe
force-pushed
the
FFM-9086
branch
from
2f73a51
to
36b33e7
Compare
ribeirophillipe
changed the title
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Show resolved
Hide resolved
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall looks good.
There is some whitespace changes to files that can be reverted.
Take a look at the descriptions fro the resources, I think these need some changes.
One query over the sleep - do we need to use it, could we check the resp code from the create operation?
ribeirophillipe
force-pushed
the
FFM-9086
branch
from
ff76f66
to
8578add
Compare
davejohnston
reviewed
Sep 1, 2023
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
davejohnston
previously approved these changes
Sep 1, 2023
rathodmeetsatish
requested changes
Sep 1, 2023
|
trigger build |
rathodmeetsatish
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Comment Triggers
PR Check triggers
trigger buildtrigger subcategoryfieldcheck