Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for target_group #694

Merged
merged 17 commits into from
Sep 18, 2023
Merged

Add fixes for target_group #694

merged 17 commits into from
Sep 18, 2023

Conversation

ribeirophillipe
Copy link
Contributor

Describe your changes

  • Change the type when creating the target group
  • Add fix for target type

Comment Triggers

PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

davejohnston
davejohnston previously approved these changes Sep 15, 2023
Copy link

@davejohnston davejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.
Do we have unit tests that can help verify the behaviour?

@ribeirophillipe
Copy link
Contributor Author

@davejohnston I've updated the functional tests to test the behaviors as you can see in the PR.

@ribeirophillipe ribeirophillipe merged commit a6c91e7 into main Sep 18, 2023
3 checks passed
@ribeirophillipe ribeirophillipe deleted the debug_terraform branch September 18, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants