generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixes for target_group #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirophillipe
requested review from
davejohnston,
rssnyder and
rathodmeetsatish
September 14, 2023 19:03
ribeirophillipe
force-pushed
the
debug_terraform
branch
from
September 14, 2023 19:04
528a94d
to
303b652
Compare
internal/service/platform/feature_flag_target_group/resource_feature_flag_target_group.go
Outdated
Show resolved
Hide resolved
davejohnston
previously approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
Do we have unit tests that can help verify the behaviour?
examples/resources/harness_platform_feature_flag_target_group/resource.tf
Show resolved
Hide resolved
@davejohnston I've updated the functional tests to test the behaviors as you can see in the PR. |
* Change the type when creating the target group * Add fix for target type
ribeirophillipe
force-pushed
the
debug_terraform
branch
from
September 17, 2023 20:17
5e7ceda
to
6c83b13
Compare
rathodmeetsatish
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Comment Triggers
PR Check triggers
trigger build
trigger subcategoryfieldcheck
trigger gitleaks