Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI-9639: added github_app support in http credentials #703

Merged
merged 5 commits into from
Oct 3, 2023
Merged

CI-9639: added github_app support in http credentials #703

merged 5 commits into from
Oct 3, 2023

Conversation

sahithibanda01
Copy link
Contributor

Describe your changes

Comment Triggers

PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

rathodmeetsatish
rathodmeetsatish requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@rathodmeetsatish rathodmeetsatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test in github_test.go and test it pointing to qa and prod

smjt-h
smjt-h reviewed Sep 27, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@smjt-h
Copy link

smjt-h commented Sep 29, 2023

Validate support for datasource as well harness_platform_connector_github

smjt-h
smjt-h previously approved these changes Sep 29, 2023
View reviewed changes
rathodmeetsatish
rathodmeetsatish requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@rathodmeetsatish rathodmeetsatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog file corresponding to your pr number

rathodmeetsatish
rathodmeetsatish requested changes Oct 3, 2023
View reviewed changes
.changelog/703.txt Outdated Show resolved Hide resolved
@sahithibanda01 sahithibanda01 merged commit 87c52c3 into main Oct 3, 2023
3 checks passed
@sahithibanda01 sahithibanda01 deleted the CI-9639 branch October 3, 2023 07:01
RajBaviskar added a commit that referenced this pull request Oct 18, 2023
@RajBaviskar
Revert "CI-9639: added github_app support in http credentials (#703)"
76e4afd 
This reverts commit 87c52c3.
@RajBaviskar RajBaviskar mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathodmeetsatish rathodmeetsatish rathodmeetsatish approved these changes

@smjt-h smjt-h smjt-h left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sahithibanda01 @smjt-h @rathodmeetsatish