Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CDS-82953]: Add force delete option for aws, azure, gcp, k8s, rancher, oci and helm connectors #743

Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix: [CDS-82953]: Add force delete option for aws, azure, gcp, k8s, rancher, oci and helm connectors #743

merged 4 commits into from
Nov 10, 2023

Conversation

abosii-harness
Copy link
Contributor

Describe your changes

This changes provide the force_delete option for next connectors:

  • GCP
  • AWS
  • Azure
  • Kubernetes
  • Rancher
  • Oci Helm
  • Http Helm

Comment Triggers

PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@abosii-harness
Copy link
Contributor Author

Doc ticket: https://harness.atlassian.net/browse/DOC-3888

acasian-harness
acasian-harness previously approved these changes Nov 8, 2023
View reviewed changes
rathodmeetsatish
rathodmeetsatish requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@rathodmeetsatish rathodmeetsatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include connector tests in terraform cd pipeline

@abosii-harness abosii-harness merged commit a0d5e27 into main Nov 10, 2023
3 checks passed
@abosii-harness abosii-harness deleted the cds-82953-tf-prov-conn-force branch November 10, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathodmeetsatish rathodmeetsatish rathodmeetsatish approved these changes

@abhinavsingh1196 abhinavsingh1196 abhinavsingh1196 approved these changes

@GoelPratyush99 GoelPratyush99 GoelPratyush99 approved these changes

@TarunUba1 TarunUba1 TarunUba1 approved these changes

@acasian-harness acasian-harness acasian-harness left review comments

@markoharness markoharness Awaiting requested review from markoharness

@alebuh alebuh Awaiting requested review from alebuh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abosii-harness @acasian-harness @rathodmeetsatish @abhinavsingh1196 @GoelPratyush99 @TarunUba1