updated code and fixed health issues

harpreetseera · Apr 29, 2020 · 0472881 · 0472881
1 parent f6d6bbe
commit 0472881
Show file tree

Hide file tree

Showing 8 changed files with 63 additions and 39 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## [0.0.2] - Release 
+
+* Fixed Health issues
+
 ## [0.0.1] - Release 
 
 * Customizable account selection modal bottom sheet widgets

diff --git a/example/lib/home_screen.dart b/example/lib/home_screen.dart
@@ -53,15 +53,14 @@ class _HomeScreenWidgetState extends State<HomeScreenWidget> {
                 selectedRadioColor: Colors.amber, //Optional
                 unselectedTextColor: Colors.white, //Optional
                 selectedTextColor: Colors.amber, //Optional
-               //Optional
+                //Optional
                 tapCallback: (index) {
-
                   setState(() {
                     resultText =
                         "selected account is : ${accountList[index].title}";
                   });
                   print(resultText);
-                }, 
+                },
                 //Optional
                 addAccountTapCallback: () {
                   setState(() {

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -7,7 +7,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.0.1"
+    version: "0.0.2"
   archive:
     dependency: transitive
     description:
@@ -109,6 +109,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.6.4"
+  pedantic:
+    dependency: transitive
+    description:
+      name: pedantic
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.8.0+1"
   petitparser:
     dependency: transitive
     description:
@@ -169,7 +176,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.15"
+    version: "0.2.11"
   typed_data:
     dependency: transitive
     description:

diff --git a/lib/account_selector.dart b/lib/account_selector.dart
@@ -34,7 +34,6 @@ showAccountSelectorSheet({
     backgroundColor: Colors.transparent,
     isDismissible: isSheetDismissible,
     isScrollControlled: true,
-    enableDrag: true,
     builder: (context) {
       return SingleAccountSelectionWidget(
         accountwithselectionList: accountwithselectionList,
@@ -57,7 +56,7 @@ showAccountSelectorSheet({
 Future<List<int>> showMultiAccountSelectorSheet({
   @required BuildContext context,
   @required List<Account> accountList,
-  List<int> initiallySelectedIndexList ,
+  List<int> initiallySelectedIndexList,
   Color checkedIconColor = Colors.green,
   Color doneButtonColor = Colors.blue,
   Color arrowColor = Colors.grey,
@@ -77,12 +76,11 @@ Future<List<int>> showMultiAccountSelectorSheet({
       context: context,
       backgroundColor: Colors.transparent,
       isScrollControlled: true,
-      enableDrag: true,
       isDismissible: isSheetDismissible,
       builder: (context) {
         return MultiAccountSelectionWidget(
           accountwithselectionList: accountwithselectionList,
-          initiallySelectedIndexList: initiallySelectedIndexList??[-1],
+          initiallySelectedIndexList: initiallySelectedIndexList ?? [-1],
           checkedIconColor: checkedIconColor,
           doneText: doneText,
           doneButtonColor: doneButtonColor,

diff --git a/lib/selector_widget.dart/muti_account_selector.dart b/lib/selector_widget.dart/muti_account_selector.dart
@@ -57,7 +57,10 @@ class _MultiAccountSelectionWidgetState
         mainAxisSize: MainAxisSize.min,
         children: <Widget>[
           IconButton(
-            icon: Icon(Icons.keyboard_arrow_down, color: widget.arrowColor),
+            icon: Icon(
+              Icons.keyboard_arrow_down,
+              color: widget.arrowColor,
+            ),
             onPressed: () {
               Navigator.of(context).pop();
             },
@@ -82,7 +85,9 @@ class _MultiAccountSelectionWidgetState
                           height: 56,
                           width: 56,
                           decoration: BoxDecoration(
-                              shape: BoxShape.circle, color: Colors.grey[200]),
+                            shape: BoxShape.circle,
+                            color: Colors.grey[200],
+                          ),
                           child: widget.accountwithselectionList[index]
                               .accountImageWidget,
                         ),
@@ -110,7 +115,7 @@ class _MultiAccountSelectionWidgetState
                             } else {
                               currentlySelectedIndexList.add(index);
                             }
-                              },
+                          },
                         );
                       },
                     ),

diff --git a/lib/selector_widget.dart/single_account_selector.dart b/lib/selector_widget.dart/single_account_selector.dart
@@ -58,7 +58,10 @@ class _SingleAccountSelectionWidgetState
         mainAxisSize: MainAxisSize.min,
         children: <Widget>[
           IconButton(
-            icon: Icon(Icons.keyboard_arrow_down, color: widget.arrowColor),
+            icon: Icon(
+              Icons.keyboard_arrow_down,
+              color: widget.arrowColor,
+            ),
             onPressed: () {
               Navigator.of(context).pop();
             },
@@ -72,7 +75,7 @@ class _SingleAccountSelectionWidgetState
                 maxWidth: double.maxFinite,
               ),
               child: Padding(
-                padding: const EdgeInsets.only(bottom:16.0),
+                padding: const EdgeInsets.only(bottom: 16.0),
                 child: ListView.builder(
                   shrinkWrap: true,
                   physics: BouncingScrollPhysics(),
@@ -88,7 +91,8 @@ class _SingleAccountSelectionWidgetState
                                   shape: BoxShape.circle,
                                   color: Colors.grey[200]),
                               child: index ==
-                                      (widget.accountwithselectionList.length - 1)
+                                      (widget.accountwithselectionList.length -
+                                          1)
                                   ? CircleAvatar(
                                       radius: 28,
                                       backgroundColor: Colors.grey[200],
@@ -108,28 +112,28 @@ class _SingleAccountSelectionWidgetState
                                 : widget.unselectedTextColor,
                           ),
                         ),
-                        trailing:
-                            index == (widget.accountwithselectionList.length - 1)
-                                ? Offstage()
-                                : Icon(
-                                    (index == currentIndex)
-                                        ? Icons.radio_button_checked
-                                        : Icons.radio_button_unchecked,
-                                    color: (index == currentIndex)
-                                        ? widget.selectedRadioColor
-                                        : widget.unselectedRadioColor),
-                        onTap:
-                            index == (widget.accountwithselectionList.length - 1)
-                                ? widget.addAccountTapCallback
-                                : () {
-                                    setState(() {
-                                      currentIndex = index;
-                                    });
-                                    if (widget.hideSheetOnItemTap) {
-                                      Navigator.of(context).pop();
-                                    }
-                                    widget.tapCallback(index);
-                                  },
+                        trailing: index ==
+                                (widget.accountwithselectionList.length - 1)
+                            ? Offstage()
+                            : Icon(
+                                (index == currentIndex)
+                                    ? Icons.radio_button_checked
+                                    : Icons.radio_button_unchecked,
+                                color: (index == currentIndex)
+                                    ? widget.selectedRadioColor
+                                    : widget.unselectedRadioColor),
+                        onTap: index ==
+                                (widget.accountwithselectionList.length - 1)
+                            ? widget.addAccountTapCallback
+                            : () {
+                                setState(() {
+                                  currentIndex = index;
+                                });
+                                if (widget.hideSheetOnItemTap) {
+                                  Navigator.of(context).pop();
+                                }
+                                widget.tapCallback(index);
+                              },
                       ),
                     );
                   },

diff --git a/pubspec.lock b/pubspec.lock
@@ -95,6 +95,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.6.4"
+  pedantic:
+    dependency: transitive
+    description:
+      name: pedantic
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.8.0+1"
   petitparser:
     dependency: transitive
     description:
@@ -155,7 +162,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.15"
+    version: "0.2.11"
   typed_data:
     dependency: transitive
     description:

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: account_selector
 description: A Flutter package which provides helper widgets for selecting single or multiple account/user from the given list.
-version: 0.0.1
+version: 0.0.2
 author: Harpreet Seera <harpreetseera8525@gmail.com>
 homepage: https://github.com/harpreetseera/flutter_account_selector