Sort input atoms in ascending order. Fixes #179

harrisiirak · May 20, 2020 · 110a823 · 110a823
1 parent fc44dab
commit 110a823
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/expression.js b/lib/expression.js
@@ -251,7 +251,12 @@ CronExpression._parseField = function _parseField (field, value, constraints) {
       }
     }
 
-    var atoms = val.split(',');
+    var atoms = val
+      .split(',')
+      .sort(function(a, b) {
+        return a.localeCompare(b);
+      });
+
     if (atoms.length > 1) {
       for (var i = 0, c = atoms.length; i < c; i++) {
         handleResult(parseRepeat(atoms[i]));

diff --git a/test/expression.js b/test/expression.js
@@ -968,6 +968,21 @@ test('day and date in week should matches', function(t){
   t.end();
 });
 
+test('should sort ranges and values in ascending order', function(t) {
+  var interval = CronExpression.parse('0 12,13,10,1-3 * * *');
+  t.ok(interval, 'Interval parsed');
+
+  var hours = [ 1, 2, 3, 10, 12, 13 ];
+  for (var i in hours) {
+    next = interval.next();
+
+    t.ok(next, 'Found next scheduled interval');
+    t.equal(next.getHours(), hours[i], 'Hours matches');
+  }
+
+  t.end();
+});
+
 test('valid ES6 iterator should be returned if iterator options is set to true', function(t) {
   try {
     var options = {