Switch from moment-timezone to luxon for smaller bundle #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson
force-pushed
the
feature/switch-to-luxon
branch
2 times, most recently
from
d6a2d52
to
b323595
Compare
|
@andytson thanks for your contribution! LGTM but I'll in depth review ASAP. I'm also thinking about releasing this as a new major version (3.0). |
andytson
commented
Jan 1, 2021
harrisiirak
reviewed
Jan 3, 2021
andytson
force-pushed
the
feature/switch-to-luxon
branch
3 times, most recently
from
61b5563
to
3d42662
Compare
Luxon uses Intl APIs for IANA timezones rather than bundling them Note: CronDate implemented to support the same types the typescript definitions define, rather than moment's additional array/object timestamp support that could have potentially been used before.
for ability to switch to another date library later
andytson
force-pushed
the
feature/switch-to-luxon
branch
from
eb75cdd
to
7a9453f
Compare
Removing unnecessary bad format handling
andytson
force-pushed
the
feature/switch-to-luxon
branch
from
7a9453f
to
f8f68a7
Compare
harrisiirak
approved these changes
Jan 10, 2021
|
@andytson https://github.com/harrisiirak/cron-parser/releases/tag/3.0.0 and I also published it to npm. Thank for your hard work and the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luxon uses Intl APIs for IANA timezones rather than bundling them
Note: CronDate implemented to support the same types the typescript definitions define, rather than moment's additional array/object timestamp support that could have potentially been used before. - I can add that if necessary
Fixes #195