Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback for gitlab.move_to_discussion_tree_from_diagnostic #309

Open
jakubbortlik opened this issue Jun 6, 2024 · 0 comments · May be fixed by #352
Open

Fallback for gitlab.move_to_discussion_tree_from_diagnostic #309

jakubbortlik opened this issue Jun 6, 2024 · 0 comments · May be fixed by #352
Labels
feature request New feature or request

Comments

@jakubbortlik
Copy link
Collaborator

Feature Description

In my gitlab.nvim config I've mapped both gitlab.move_to_discussion_tree_from_diagnostic and jump_to_reviewer to the same key (a) and I use it to quickly jump between the discussion tree and the reviewer. This workflow is interrupted when jumping to the reviewer for a resolved thread with settings.discussion_signs.skip_resolved_discussion = true. Then I just get the warning "No diagnostics for this line".

I'd like the gitlab.move_to_discussion_tree_from_diagnostic function to allow a fallback for such cases. Instead of just showing a warning, I'd like focus to be brought to the last position in the discussion tree.

I imagine it should be fairly easy to implement as an opt-in feature, so the default behaviour would not change. I can open a PR after the other pending PR are sorted out.

@harrisoncramer harrisoncramer added the feature request New feature or request label Jun 15, 2024
@jakubbortlik jakubbortlik linked a pull request Aug 23, 2024 that will close this issue
@jakubbortlik jakubbortlik linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants