Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support code completion #13

Closed
harrisont opened this issue Feb 25, 2023 · 3 comments · Fixed by #73
Closed

Support code completion #13

harrisont opened this issue Feb 25, 2023 · 3 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@harrisont
Copy link
Owner

Docs
@harrisont harrisont added the enhancement New feature or request label Feb 25, 2023
harrisont pushed a commit that referenced this issue May 27, 2023
Refactor required properties
2d97106 
WIP Support auto-completion for variables (#13)
@harrisont
Copy link
Owner Author

WIP in branch issue-13.
Before making progress, need to be able to lookup the AST by position to determine which possible completions there can be.

@harrisont harrisont pinned this issue Dec 19, 2023
@harrisont
Copy link
Owner Author

harrisont commented Dec 19, 2023 •
edited

Remaining work:

  • Fill in the rest of the function properties (the optional ones) in server/src/genericFunctions.ts.
  • Change server/src/features/completionProvider.ts to do a binary search instead of linear.

@harrisont
Copy link
Owner Author

Finished adding code completion for function properties.
There's still a future opportunity to add completion for other things, like accessible variables or function names, but that will be tracked in a future issue.

@harrisont harrisont mentioned this issue Dec 22, 2023
Merged
harrisont added a commit that referenced this issue Dec 22, 2023
@harrisont
Support auto-completion for function properties, including documentat…
f764283 
…ion (#73)

Example:
<img width="1111" alt="image" src="https://github.com/harrisont/fastbuild-vscode/assets/144260/fb0ccd56-5b12-41f5-9b29-4ca7f34027ee">

Fixes #13.

Also fixes a bug with `parser.isPositionInRange` for multi-line ranges.

There's still a future opportunity to add completion for other things, like accessible variables or function names, but that will be tracked in a future issue.
@harrisont harrisont unpinned this issue Dec 22, 2023
@harrisont harrisont mentioned this issue Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support auto-completion for function properties, including documentation harrisont/fastbuild-vscode
1 participant
@harrisont