Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize by deduplicating evaluated data #28

Closed
harrisont opened this issue Apr 6, 2023 · 2 comments
Closed

Optimize by deduplicating evaluated data #28

harrisont opened this issue Apr 6, 2023 · 2 comments
Labels
performance

Comments

@harrisont
Copy link
Owner

Specifically by deduplicating the following fields in evaluated data:

  • variableReferences with the same range
  • variableDefinitions returned by getDocumentSymbols/getWorkspaceSymbols with the same name and range
harrisont pushed a commit that referenced this issue Apr 6, 2023
Stop returning duplicates for "get document symbols" (#28)
57925a3
harrisont pushed a commit that referenced this issue Apr 6, 2023
Stop returning duplicates for "get workspace symbols" (#28)
3847612 
Experimentally, this makes the operation twice as fast.
@harrisont harrisont mentioned this issue Apr 6, 2023
Merged
@harrisont
Copy link
Owner Author

The remaining work is to deduplicate the evaluated data's variableReferences with the same range.

@harrisont harrisont mentioned this issue Apr 7, 2023
Open
@harrisont
Copy link
Owner Author

Splitting out the remaining work into #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harrisont