Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp for GNOME 45 #207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revamp for GNOME 45 #207

wants to merge 2 commits into from

Conversation

adhadse
Copy link

@adhadse adhadse commented Nov 13, 2023 •
edited
Loading

Resolves #206

@adhadseKavida
Copy link

I don't really have a background in TS/GJS and would appreciate someone's help on this for review and further refactoring.

smedir
smedir reviewed Nov 13, 2023
View reviewed changes
metadata.json Outdated Show resolved Hide resolved
@smedir
Copy link

smedir commented Nov 13, 2023

Resolves #206

I was refactoring this as well, 👍 , had just started. You are way ahead. All yours.

smedir
smedir reviewed Nov 13, 2023
View reviewed changes
extension/extension.ts
@@ -13,16 +13,17 @@ import { SnapWindowExtension } from './src/snapWindow';
import * as DBusUtils from './src/utils/dbus';
import * as VKeyboard from './src/utils/keyboard';

const ExtensionUtils = imports.misc.extensionUtils;
const extensionObject = Extension.lookupByUUID('gestureImprovements@gestures');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary

smedir
smedir reviewed Nov 13, 2023
View reviewed changes
extension/extension.ts
private _extensions: ISubExtension[];
settings?: GioSettings;
private _settingChangedId = 0;
private _reloadWaitId = 0;
private _addReloadDelayFor: AllSettingsKeys[];

constructor() {
super(extensionObject.metadata);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constructor(metadata: ExtensionMetadata) {
super(metadata)

extension/extension.ts Outdated

class Extension {
class GNOMEGestureImprovementsExtension extends Extension {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export default class GnomeGestureImprovements extends Extension {

line 156 is not necessary??

extension/extension.ts
@@ -1,5 +1,5 @@
import GLib from '@gi-types/glib2';
import { imports } from 'gnome-shell';
import { Extension } from 'resource:///org/gnome/shell/extensions/extension';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( Extension, ExtensionMetadata} from ....

@adhadse
bug fixes
cff464c 
- remove older version of gnome from supported list
- Add `ISubExtension` and `IExtension` to `global.d.ts`.
@adhadse
Copy link
Author

adhadse commented Nov 17, 2023

Maybe I can learn from this PR for pano (clipboard manager)

@MaddyGuthridge
Copy link

Is there any news on this? This extension is currently keeping me on Fedora 38, which goes EOL in about 3 months' time. If there's anything I can do to get the extension updated, please let me know!

@luismxlina luismxlina mentioned this pull request Mar 30, 2024
Open
@sidevesh
Copy link

It would be great if this branch can be merged in,
in the meantime I have pushed a release on https://github.com/sidevesh/gnome-gesture-improvements--transpiled which contains the transpiled version with fixes that a bunch of folks have done to get it working on Gnome 46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smedir smedir smedir left review comments

@CristianArean CristianArean CristianArean approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] GNOME 45 Support
6 participants
@adhadse @adhadseKavida @smedir @MaddyGuthridge @sidevesh @CristianArean