[Feature Request] GNOME 45 Support #206

luismxlina · 2023-10-22T11:54:20Z

This extension works and feels as if it should be native on Gnome DE for every laptop. It's great.

The process to adapt existing extensions to the problematic Gnome Shell 45 it is sort of explained here https://gjs.guide/extensions/upgrading/gnome-shell-45.html
However searching through the source code of this extension, every requirement, ESM imports and good practises from the previous guide are already achieved, so changing the metadata.json file, and leaving "45" as the only compatible version, for then reinstalling and enabling "Gestures Improvements" apparently should do the trick. Sadly it doesn't, and the next error is thrown when trying to load the extension:

The settings of extension gestureImprovements@gestures had an error:

SyntaxError: import declarations may only appear at top level of a module


Stack trace:

@file:///home/lviz/.local/share/gnome-shell/extensions/gestureImprovements@gestures/prefs.js:4:12
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

I hope @harshadgavali, collaborators or any interested and experienced programmer can find a solution, or guide unexperienced programmers as me to fix this great tool.

The text was updated successfully, but these errors were encountered:

logans3c · 2023-10-27T07:27:35Z

you got any solutions ?

luismxlina · 2023-10-27T11:26:34Z

you got any solutions ?

@jaophi got the transpiled version of the source code working, because this project is made with TypeScript. It's not a perfect solution, but it works for now and we gotta give props to this man. I quote him here in case someone didn't see the previous issue: https://github.com/harshadgavali/gnome-gesture-improvements/issues/199#issuecomment-1752162371

Hey guys, I did the necessary changes to run in GNOME 45, here's the zip: gestureImprovements@gestures.zip

I can't make a PR because I don’t know how to make those changes (ESM imports) work with all the ts transpilation this project uses, I just applied them in the final (js) zip release.

The process to get it running:

Save gestureImprovements@gestures.zip on ~/Downloads

gnome-extensions install -f ~/Downloads/gestureImprovements@gestures.zip

Logout and login, it should be working already.

FlynnD273 · 2023-10-27T18:14:34Z

rm -rf ~/.local/share/gnome-shell/extensions/gestureImprovements@gestures;
unzip ~/Downloads/gestureImprovements@gestures.zip;
cp -r ~/Downloads/gestureImprovements@gestures ~/.local/share/gnome-shell/extensions/;
gnome-extensions enable gestureImprovements@gestures;

You can alternatively just run gnome-extensions install -f ~/Downloads/gestureImprovements@gestures.zip instead. The -f flag will overwrite the extension if it's already installed.

Neo-29 · 2023-10-29T00:18:43Z

Could someone fork and update the project please?

FlynnD273 · 2023-10-29T03:28:15Z

As discussed previously, that takes a lot of work, and it requires either getting the TypeScript transpilation working, or simply maintaining a JavaScript-only version both of which are... complicated

grigio · 2023-10-31T19:05:11Z

+1 please

mbeps · 2023-11-06T19:44:47Z

https://github.com/JoseExposito/touchegg#readme

I think this is a viable alternative. I don't know if the gestures are one-to-one though.

FlynnD273 · 2023-11-06T21:08:54Z

https://github.com/JoseExposito/touchegg#readme

I think this is a viable alternative. I don't know if the gestures are one-to-one though.

It doesn't seem to work for me. The name of the companion GNOME extension for Touchegg is X11 gestures, maybe it doesn't work on Wayland?

mbeps · 2023-11-07T16:35:37Z

https://github.com/JoseExposito/touchegg#readme
I think this is a viable alternative. I don't know if the gestures are one-to-one though.

It doesn't seem to work for me. The name of the companion GNOME extension for Touchegg is X11 gestures, maybe it doesn't work on Wayland?

Yep, seems like Wayland is not supported yet. This is a major problem. Fedora 39 is out and all of my favourite extensions have also been ported except this one.

adhadse · 2023-11-13T09:02:24Z

I tried refactoring the code as per the GJS port extension guide for GNOME 45.

Will need to update how the transpilation works, I'll need help.

HubKing · 2024-01-27T01:16:03Z

Is this project abandoned? Looks like the owner has not posted anything over half a year. Also, why is this issue not going anywhere? Is this because the problem is on Gnome's side and it cannot be fixed until Gnome developers make some changes?

Neo-29 · 2024-01-28T11:12:52Z

Is this project abandoned? Looks like the owner has not posted anything over half a year. Also, why is this issue not going anywhere? Is this because the problem is on Gnome's side and it cannot be fixed until Gnome developers make some changes?

The Zip version given above is fully operational

https://github.com/harshadgavali/gnome-gesture-improvements/files/12841762/gestureImprovements%40gestures.zip

Only solution for the moment

nafg · 2024-01-30T17:24:12Z

Why can't that be merged in and published?

FlynnD273 · 2024-01-30T18:43:21Z

Because this extension uses TypeScript and a transpiler. The zipped file is a ported version of the transpiled code. So unless the owner wants to switch to JavaScript, it can't be merged until the source code itself is ported.

nafg · 2024-01-30T20:11:04Z

What would it take to port the existing (TS) code?

FlynnD273 · 2024-01-30T22:22:14Z

Unsure. I looked into it a little bit but wasn't familiar enough with how the custom transpilers work generally (and specifically this one). I'm hesitant to speculate at the complexity of porting the TypeScript code. Hopefully someone else has more experience than I

7HE-W0R1D · 2024-03-27T17:43:12Z

Coming from GNOME 46, I changed the GNOME version to 46 and version to 27 in metadata.json and its still working perfectly! Credit to @joaophi for porting it and @luismxlina for the install instructions. Post the zip here to save others' time editing the files.

gestureImprovements46@gestures.zip

medicamin · 2024-03-28T11:41:46Z

Coming from GNOME 46, I changed the GNOME version to 46 and version to 27 in metadata.json and its still working perfectly! Credit to @joaophi for porting it and @luismxlina for the install instructions. Post the zip here to save others' time editing the files.

gestureImprovements46@gestures.zip

I get this error in gnome 46 by your zip file:
Error: No signal 'actor-added' on object 'Gjs_ui_layout_UiActor'
Any idea?

7HE-W0R1D · 2024-03-28T14:37:36Z

Coming from GNOME 46, I changed the GNOME version to 46 and version to 27 in metadata.json and its still working perfectly! Credit to @joaophi for porting it and @luismxlina for the install instructions. Post the zip here to save others' time editing the files.
gestureImprovements46@gestures.zip

I get this error in gnome 46 by your zip file: Error: No signal 'actor-added' on object 'Gjs_ui_layout_UiActor' Any idea?

I'm using Fedora 40 beta with GNOME 46 but cannot replicate the error on my side, however, I remember seeing this actor related comment in the dash to dock pull request for GNOME 46 micheleg/dash-to-dock#2146 (comment)

Yanndroid · 2024-03-28T23:55:18Z

@medicamin
For the signal error change "actor-added" to "child-added" in src/snapWindow.js at line 266.

medicamin · 2024-03-29T07:46:52Z

@medicamin For the signal error change "actor-added" to "child-added" in src/snapWindow.js at line 266.

Thanks a lot. It's working now

luismxlina · 2024-03-30T20:16:11Z

@medicamin For the signal error change "actor-added" to "child-added" in src/snapWindow.js at line 266.

This worked fine!
Btw can someone confirm that the 3 finger pinch to close applications has broken?
Btw 2: Github forces me to "close this issue as not planned" because of the fork that was made #207 but feel free to discuss and comment anything related

swapisticated · 2024-04-14T20:41:13Z

@medicamin For the signal error change "actor-added" to "child-added" in src/snapWindow.js at line 266.

This worked fine! Btw can someone confirm that the 3 finger pinch to close applications has broken? Btw 2: Github forces me to "close this issue as not planned" because of the fork that was made #207 but feel free to discuss and comment anything related

3 finger pinch and 4 finger pinch to close applications and to invoke ctrl + w command, does not seem to work for me too. Do you have any solution for this?

@joaophi

…ment) which bumps support for 46 on the transpiled version from @joaophi

@Yanndroid

…omment), by @Yanndroid

sidevesh · 2024-04-25T18:34:05Z

I have pushed the transpiled version as a repo to https://github.com/sidevesh/gnome-gesture-improvements--transpiled with all the fixes from this thread and also two PRs from me which were never merged,
#202
#203

all credit goes to the everyone who fixed the issues and got this transpiled and working,
let me know if I missed crediting someone on the repo.

The issue of 3 and 4 finger pinch is still not working but I will be taking a look at fixing that, would appreciate help!

Beast-Viper · 2024-04-28T11:53:30Z

My Workspace switching gesture (4 finger swipe) is also not working. Any fixes?

…rshadgavali#215)

adhadse linked a pull request Nov 13, 2023 that will close this issue

Revamp for GNOME 45 #207

Open

2 tasks

suvanbanerjee mentioned this issue Apr 14, 2024

version: added support for gnome 45 #210

Open

sidevesh added a commit to sidevesh/gnome-gesture-improvements--transpiled that referenced this issue Apr 25, 2024

Initial commit from harshadgavali/gnome-gesture-improvements#206 (com…

eb32012

…ment) which bumps support for 46 on the transpiled version from @joaophi

sidevesh added a commit to sidevesh/gnome-gesture-improvements--transpiled that referenced this issue Apr 25, 2024

Fix signal error from harshadgavali/gnome-gesture-improvements#206 (c…

8e54696

…omment), by @Yanndroid

sidevesh mentioned this issue Apr 25, 2024

Pinch gesture not working sidevesh/gnome-gesture-improvements--transpiled#1

Closed

HieuTNg added a commit to HieuTNg/gnome-gesture-improvements that referenced this issue Jul 27, 2024

Update: add support for GNOME 45 (harshadgavali#206) and GNOME 46 (ha…

70eeff7

…rshadgavali#215)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature Request] GNOME 45 Support #206

[Feature Request] GNOME 45 Support #206

luismxlina commented Oct 22, 2023 •

edited

Loading

logans3c commented Oct 27, 2023

luismxlina commented Oct 27, 2023 •

edited

Loading

FlynnD273 commented Oct 27, 2023

Neo-29 commented Oct 29, 2023

FlynnD273 commented Oct 29, 2023

grigio commented Oct 31, 2023

mbeps commented Nov 6, 2023

FlynnD273 commented Nov 6, 2023

mbeps commented Nov 7, 2023

adhadse commented Nov 13, 2023

HubKing commented Jan 27, 2024

Neo-29 commented Jan 28, 2024 •

edited

Loading

nafg commented Jan 30, 2024

FlynnD273 commented Jan 30, 2024

nafg commented Jan 30, 2024

FlynnD273 commented Jan 30, 2024

7HE-W0R1D commented Mar 27, 2024

medicamin commented Mar 28, 2024

7HE-W0R1D commented Mar 28, 2024 •

edited

Loading

Yanndroid commented Mar 28, 2024

medicamin commented Mar 29, 2024

luismxlina commented Mar 30, 2024 •

edited

Loading

swapisticated commented Apr 14, 2024 •

edited

Loading

sidevesh commented Apr 25, 2024

Beast-Viper commented Apr 28, 2024

[Feature Request] GNOME 45 Support #206

[Feature Request] GNOME 45 Support #206

Comments

luismxlina commented Oct 22, 2023 • edited Loading

logans3c commented Oct 27, 2023

luismxlina commented Oct 27, 2023 • edited Loading

FlynnD273 commented Oct 27, 2023

Neo-29 commented Oct 29, 2023

FlynnD273 commented Oct 29, 2023

grigio commented Oct 31, 2023

mbeps commented Nov 6, 2023

FlynnD273 commented Nov 6, 2023

mbeps commented Nov 7, 2023

adhadse commented Nov 13, 2023

HubKing commented Jan 27, 2024

Neo-29 commented Jan 28, 2024 • edited Loading

nafg commented Jan 30, 2024

FlynnD273 commented Jan 30, 2024

nafg commented Jan 30, 2024

FlynnD273 commented Jan 30, 2024

7HE-W0R1D commented Mar 27, 2024

medicamin commented Mar 28, 2024

7HE-W0R1D commented Mar 28, 2024 • edited Loading

Yanndroid commented Mar 28, 2024

medicamin commented Mar 29, 2024

luismxlina commented Mar 30, 2024 • edited Loading

swapisticated commented Apr 14, 2024 • edited Loading

sidevesh commented Apr 25, 2024

Beast-Viper commented Apr 28, 2024

luismxlina commented Oct 22, 2023 •

edited

Loading

luismxlina commented Oct 27, 2023 •

edited

Loading

Neo-29 commented Jan 28, 2024 •

edited

Loading

7HE-W0R1D commented Mar 28, 2024 •

edited

Loading

luismxlina commented Mar 30, 2024 •

edited

Loading

swapisticated commented Apr 14, 2024 •

edited

Loading