Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4 finger Vertical gesture for app navigation #98

Open
wants to merge 172 commits into
base: main
Choose a base branch
from

Conversation

adhadse
Copy link

@adhadse adhadse commented Jun 12, 2022

The current state of using 3 fingers for both WIndow Switching and app navigation can be harder to get familiarized or even miss. Mapping these gestures to 4 finger in Vertical direction make things a lot easier and they are also not used (Edit: oh well they are used for WIndow Manipulation, but might be less frequently used in comparison to app navigation).

When default overview navigation gesture using 3-finger is on:

  • 4 finger downward motion do forward navigation.
  • 4 finger upward motion do backward navigation.

When default overview navigation gesture using 3 fingers is TURNED OFF using extension, i.e., overview gesture uses 4 finger instead (and window manipulation is on).

  • 3 finger left motion do forward navigation.
  • 3 finger right motion do backward navigation.

I have tested them and they work pretty fine.

And Heartful Thanks for this extensione🤩. Any plan to bake this into GNOME?

harshadgavali and others added 30 commits August 7, 2021 00:55
This doesn't affect fullscreen mode, as in fullscreen mode
panel is visible, but panel's parent is hidden.

Fixes harshadgavali#5
This avoids glitch where widget containing window's content is shown
above Tilepreview for very short duration, without any animation
This change makes touchscreen gesture behave as default
AchimStuy and others added 17 commits April 20, 2022 02:07
This is to avoid waiting for bindings to be available on npmjs
This makes both window switching and forwardBack gestures available
V22: Add close tab/window gesture and make forwardBack a hold-swipe gesture
This fixes issue when confirmPinch was not called, so tracker remains
in pending-ack state
…sture

This allows cyclic overview navigation as well as gnome-style navigation.
It also adds option for only desktop<->windowPicker transitions
@harshadgavali
Copy link
Owner

@adhadse It would be better to add option to replace window manipulation gesture with forward/back gesture regardless whether overview gesture are 3 or 4 fingers.

Though I'm still not convinced that would be better cause forward/back is horizontal action not vertical one.

@adhadse
Copy link
Author

adhadse commented Jun 15, 2022

@harshadgavali I think we are trying to put a lot of features which GNOME ecosystem tries to stay away from.

It would be whole lot better if we offer user what gesture he/she want to use for what. Like WIndows do (We can learn from them...) giving dropdown options to choose from
image
and as a extension developer we need to only care about these gestures don't conflict with each other.

So, the user can decide if he/she wants navigation to be horizontal/vertial and 4/3 finger to suit their priority and needs, and then we give them option for possible gestures they are left with.

Thoughts?

@harshadgavali
Copy link
Owner

I think you misunderstood what I meant.
While I still think assigning horizontal actions to vertical gesture is not natural, I'm still willing to add them.

What I meant is in this PR

  • We should add option(dropdown option) to replace window navigation with app gestures (regardless of user's preference for 3/4 finger overview gestures).
  • And also change app gesture animation to vertical if app gesture are replacing window navigation (and horizontal animation if we prefer current settings).

harshadgavali and others added 2 commits June 21, 2022 11:55
…states

overviewRoundTrip: Add option to set navigation states for overview gesture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants