Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conform to pep8 guidelines #7

Merged
merged 3 commits into from
Jul 2, 2015
Merged

conform to pep8 guidelines #7

merged 3 commits into from
Jul 2, 2015

Conversation

SanketDG
Copy link
Contributor

@SanketDG SanketDG commented Jul 2, 2015

Hey just fixed your code to conform to pep8.

Thanks!

@harshasrinivas
Copy link
Owner

make sure that the __future__ import lines are placed at the beginning of the file.

@SanketDG
Copy link
Contributor Author

SanketDG commented Jul 2, 2015

Yeah, ok. Done!

You should turn off Travis CI, you have no tests.

@harshasrinivas
Copy link
Owner

Cool. Just put these two lines on top as well.
from future.standard_library import install_aliases
install_aliases()

It is used to make the module urllib.request compatible with python 2.x!

@harshasrinivas
Copy link
Owner

And thanks for fixing the typo! 👍

@SanketDG
Copy link
Contributor Author

SanketDG commented Jul 2, 2015

It is used to make the module urllib.request compatible with python 2.x!

Oh! I see. Sorry for that.
btw I removed from string import * is that okay?

@harshasrinivas
Copy link
Owner

yes, string module is important. it is what is responsible for the find() method to work

@SanketDG
Copy link
Contributor Author

SanketDG commented Jul 2, 2015

Well, have you every tried using find without importing string module? It works. Every string object by default has these methods, you don't need to import anything for them to work.

@sananth12
Copy link
Collaborator

@harshasrinivas
Also, avoid import * at all costs.

https://www.python.org/dev/peps/pep-0020/

Explicit is better than implicit.

@harshasrinivas
Copy link
Owner

yeah thanks @sananth12 ! 👍
@SanketDG oh cool, thanks! You can make the remaining changes now :)

@SanketDG
Copy link
Contributor Author

SanketDG commented Jul 2, 2015

Ready for merge.

harshasrinivas pushed a commit that referenced this pull request Jul 2, 2015
conform to pep8 guidelines
@harshasrinivas harshasrinivas merged commit ddabdb6 into harshasrinivas:master Jul 2, 2015
@SanketDG SanketDG deleted the cleanup branch July 2, 2015 18:55
@harshasrinivas
Copy link
Owner

Thanks! @SanketDG , you have been added to the list of contributors 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants