Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Input box font? #8

Closed
Just-Moh-it opened this issue Jul 30, 2022 · 3 comments
Closed

[BUG] Input box font? #8

Just-Moh-it opened this issue Jul 30, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@Just-Moh-it
Copy link
Contributor

Describe the bug

For some reason, the font looks very off in the text-box... as if it were the default font

To Reproduce
Steps to reproduce the behavior:

  1. Just follow the setup instructions in the docs
  2. Open the command palette and start typing to notice it

Expected behavior
Screenshot 2022-07-30 at 6 05 45 PM

Actual Behaviour
Screenshot 2022-07-30 at 6 06 10 PM

Desktop (please complete the following information):

  • OS: macOs
  • Browser Chrome
  • Version: Chrome: 103.0, macOs 12.4
@Just-Moh-it Just-Moh-it added the bug Something isn't working label Jul 30, 2022
@Just-Moh-it
Copy link
Contributor Author

It's not that noticeable in the screenshots, but really stands out while typing stuff in the text box in an actual website

@harshhhdev
Copy link
Owner

image
image

I've done a comparison of the two, here are screenshots side by side of them. The only difference is the first one has a slightly larger font, which distorts the rendering a bit.

In the screenshot you have shown me, that's not a problem on kmenu's side -- it's a problem on your side. It's visible that the font in the input field is the default font, but the issue isn't with kmenu it's an issue with how browser styling works in-general.

By default, they do not inherit the font (the same is true with ALL form elements such as button or select), and that's something you can easily fix with some CSS. Just add in:

/* I'm assuming the font you showed me is Poppins, just replace it if it's not */
input, select, textarea, button{ font-family: 'Poppins', sans-serif; }

However, I think it's a good idea for me to put font-family: inherit in the CSS of kmenu.

harshhhdev added a commit that referenced this issue Jul 30, 2022
@harshhhdev
Copy link
Owner

Fonts will be inherited by default on kmenu v1 🍾

@harshhhdev harshhhdev added this to the v1.0.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants