disable parallelism in debug mode

harshit-bs · May 3, 2023 · 2eedda5 · 2eedda5
1 parent e3f6595
commit 2eedda5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/runner/cli/cli.js b/lib/runner/cli/cli.js
@@ -323,11 +323,6 @@ class CliRunner {
       this.argv.config = path.resolve(this.argv.config);
     }
 
-    if (!this.argv.parallel && this.argv.debug && (this.argv.env === 'chrome' || Utils.isChrome(Settings.DEFAULTS.desiredCapabilities))) {
-      Logger.log(`\n ${Logger.colors.red('Nightwatch Inspector')} is not supported in parallel mode`);
-      this.argv.serial = true;
-    }
-
     return require(this.argv.config);
   }
 
@@ -394,6 +389,12 @@ class CliRunner {
       return false;
     }
 
+    if (this.argv.debug) {
+      Logger.info('Disabling parallelism while running in debug mode');
+
+      return false;
+    }
+
     for (const env of this.testEnvArray) {
       const {webdriver = {}} = this.testEnvSettings[env];
       const desiredCapabilities = this.testEnvSettings[env].capabilities || this.testEnvSettings[env].desiredCapabilities;

diff --git a/lib/settings/settings.js b/lib/settings/settings.js
@@ -103,7 +103,7 @@ class Settings {
   get testWorkersEnabled() {
     const {test_workers} = this.settings;
 
-    return  this.argv.serial ? false : (this.argv.parallel || test_workers === true || (test_workers && test_workers.enabled && test_workers.workers !== 1));
+    return  (this.argv.serial || this.argv.debug) ? false : (this.argv.parallel || test_workers === true || (test_workers && test_workers.enabled && test_workers.workers !== 1));
   }
 
   /**

diff --git a/test/src/cli/testCliRunner.js b/test/src/cli/testCliRunner.js
@@ -1373,7 +1373,6 @@ describe('Test CLI Runner', function() {
     }).setup();
 
     assert.strictEqual(runner.argv.env, 'chrome');
-    assert.strictEqual(runner.argv.serial, true);
     assert.strictEqual(runner.test_settings.parallel_mode, false);
     assert.strictEqual(runner.test_settings.desiredCapabilities.browserName, 'chrome');
   });