Skip to content

Commit

Permalink
Blocking parallelism for default case for chrome in debug mode
Browse files Browse the repository at this point in the history
  • Loading branch information
harshit-bs committed Apr 12, 2023
1 parent 6fddbd4 commit 855041c
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/runner/cli/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ class CliRunner {
this.argv.config = path.resolve(this.argv.config);
}

if (this.argv.debug && this.argv.env === 'chrome') {
Logger.log(`\n ${Logger.colors.red('Nightwatch Inspector')} is not supported in parallel mode`);
this.argv.serial = true;
}

return require(this.argv.config);
}

Expand Down
59 changes: 59 additions & 0 deletions test/src/cli/testCliRunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -1348,5 +1348,64 @@ describe('Test CLI Runner', function() {
});
});

it('Nightwatch Inspector - By default Chrome in debug mode run serially', function() {
mockery.registerMock('./nightwatch_inspector.json', {
test_settings: {
'default': {
output: false,
silent: false
},

chrome: {
desiredCapabilities: {
browserName: 'chrome',
}
}
}
});

const CliRunner = common.require('runner/cli/cli.js');

const runner = new CliRunner({
config: './nightwatch_inspector.json',
env: 'chrome',
debug: true
}).setup();

assert.strictEqual(runner.argv.env, 'chrome');
assert.strictEqual(runner.argv.serial, true);
assert.strictEqual(runner.test_settings.parallel_mode, false);
assert.strictEqual(runner.test_settings.desiredCapabilities.browserName, 'chrome');
});

it('Nightwatch Inspector - parallel argument enables running Chrome in debug mode parallaly', function() {
mockery.registerMock('./nightwatch_inspector.json', {
test_settings: {
'default': {
output: false,
silent: false
},

chrome: {
desiredCapabilities: {
browserName: 'chrome',
}
}
}
});

const CliRunner = common.require('runner/cli/cli.js');

const runner = new CliRunner({
config: './nightwatch_inspector.json',
env: 'chrome',
debug: true,
parallel: true
}).setup();

assert.strictEqual(runner.argv.env, 'chrome');
assert.strictEqual(runner.argv.serial, undefined);
assert.strictEqual(runner.argv.parallel, true);
assert.strictEqual(runner.test_settings.desiredCapabilities.browserName, 'chrome');
});
});

0 comments on commit 855041c

Please sign in to comment.