Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Review #79

Open
rahulkore opened this issue Dec 10, 2022 · 0 comments
Open

Project Review #79

rahulkore opened this issue Dec 10, 2022 · 0 comments

Comments

@rahulkore
Copy link

#Functionality Wise

Pros

  • Good job on client side data validation
  • Wireframing looks good.
  • Good job on using API's to fetch the data for website ionstead of just static content

cons

  • After login, all the tabs show the same page.
  • On a meta level , Always remeber if certain feature you haven't implemented properly then just remove it. A Website with few working features is more
    interesting and functional than a website with n different things out of which only few works.

#Coding

  • UI

  • Pros

    • UI looks good , looks attractive , good job on that part .
    • The wireframe looks great overall.
    • The navigation is smooth on the site.
    • latency is within limits on event fires.
    • Functionality those are included works fine although some enhancements could've done .
    • Redux arch is used properly , kudos on that .
    • Hooks understanding is also on point .
    • Standard Coding practices are used .
  • Cons

    • Some links are broken(e.g. the Trends tab after login)
    • No comments in code / Always include comments
  • Backend

    • Good job on data validation.
    • Good job on authentication.
    • Use of API's for fetching data on website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant