Feature no omnijack call when package_url defined #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartmantis
added a commit
that referenced
this pull request
May 13, 2015
#48 + assorted boilerplate build fixes
|
I had to move some things around to get the build passing again, but this has been merged as part of #50 and will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time we are installing from a local artifact repository. This change eliminates the external api call when the package_url is defined.
The global_shell_init method was failing on Windows so I added a platform check and skip the call on Windows. After making the changes, RuboCop complained the action_install method had to many lines. I tried moving the unless to the same line as the global_shell_init method but then it complained the line was to long.