Python3 test discovery fix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use absolute import from the __future__ module to prepare the library for use in python 3 partial: vmware#55
Moves Iso8601 to using the print_function. NOTE(should not use print at all here) partial: vmware#55
Fixes for Python 3 with 2to3 partial vmware#55
Changes exception statements to match python 3 style partial: vmware#55
A minimal change set to deal with unicode modules and methods between python2 and python3. A deeper reworking of the unicode components is very likely called for, however, this change should get the library working on python3. partial: vmware#55
remove all old style string formatting from Soapadapter.py and move to .format() syntax for python 3 compatibility partial vmware#55
Travis CI configuration tweaks for python3 support partial: vmware#55
Code change to unit tests for python3. partial: vmware#55
|
out of time on this, there's quite a bit of work to get this module running on python3 but at least the tests run on travis now :) |
|
Thanks. I think I clobbered some of this. I'll back things up and retry merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the test discovery for python setup.py test and fix a couple python3 syntax errors. There is still quite a bit of work to do to finish the python3 port however.