Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for literals from Shopify liquid #102

Closed
danielfriis opened this issue Feb 8, 2019 · 3 comments · May be fixed by maze-consulting/liquidjs#1
Closed

Support for literals from Shopify liquid #102

danielfriis opened this issue Feb 8, 2019 · 3 comments · May be fixed by maze-consulting/liquidjs#1

Comments

@danielfriis
Copy link

danielfriis commented Feb 8, 2019

Hi,

Thanks for making this available!

Do you have any plans to support LITERALS from the Shopify liquid project?

I use blank quite extensively to enable conditional renders of certain sections in a template. It seems to be a foundational part of the Shopify liquid project: https://help.shopify.com/en/themes/liquid/basics/true-and-false#truthy

Something like this:

{% unless settings.fp_heading == blank %}
    <h1>{{ settings.fp_heading }}</h1>
{% endunless %}

Thanks!

@danielfriis danielfriis changed the title Support for Support for literals from Shopify liquid Feb 8, 2019
@scottge
Copy link

scottge commented Feb 22, 2019

I need this feature too. :)

@harttle
Copy link
Owner

harttle commented Feb 22, 2019

Currently I'm shipping Liquid to TypeScript and get it strictly typed, I'll provide this feature ASAP after that.

harttle pushed a commit that referenced this issue Feb 24, 2019
# [7.3.0](v7.2.2...v7.3.0) (2019-02-24)

### Features

* nil/null/empty/blank literals, resolves [#102](#102) ([88c9e96](88c9e96))
@scottge
Copy link

scottge commented Feb 24, 2019

This is amazing. Thank you for the work!!!

Question: I see you add the drop abstract class and interface in this commit too. Does it mean that for my own custom drops I should start to extend your drop base class and implement your IDrop interface? Would you mind adding a custom drop unit test so that I can follow your example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants