We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default
default filter is not working with an empty string. For example: https://jsfiddle.net/q3vL9dkn/
{{ null | default: "default on null"}} => "default on null" {{ "" | default: "default on empty string"}} => ""
This works well with Shopify's Liquid (check out last example): https://shopify.github.io/liquid/filters/default/
I have read source code for default filter and Differences With shopify/liquid (about truthy values) but I think we should make an exception for default filter and add an extra check for an empty string.
I can make a PR for it If you think it's a good idea. Thanks!
The text was updated successfully, but these errors were encountered:
fix: default filter is not working with an empty string, #122
6075c0a
chore(release): 8.2.1 [skip ci]
4282acc
## [8.2.1](v8.2.0...v8.2.1) (2019-04-26) ### Bug Fixes * `default` filter is not working with an empty string, [#122](#122) ([6075c0a](6075c0a))
No branches or pull requests
default
filter is not working with an empty string.For example: https://jsfiddle.net/q3vL9dkn/
This works well with Shopify's Liquid (check out last example): https://shopify.github.io/liquid/filters/default/
I have read source code for
default
filter and Differences With shopify/liquid (about truthy values) but I think we should make an exception fordefault
filter and add an extra check for an empty string.I can make a PR for it If you think it's a good idea.
Thanks!
The text was updated successfully, but these errors were encountered: