Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using certain filters on an undefined variable will throw an error #140

Closed
robinbijlani opened this issue Jul 18, 2019 · 0 comments
Closed

Using certain filters on an undefined variable will throw an error #140

robinbijlani opened this issue Jul 18, 2019 · 0 comments
Assignees
@harttle
Labels
bug

Comments

@robinbijlani
Copy link
Contributor

Thank you for the great package! 馃檱鈥嶁檧

I did run into a situation which I think may be a bug:

If you use any of the following filters on an undefined variable, they will throw an error:

  • capitalize
  • downcase
  • size
  • remove
  • first
  • last

Example: https://jsfiddle.net/wxekqcnp/3/

I would not expect this to happen because with the default options, an undefined variable should evaluate to an empty string, and these filters all work fine on an empty string:
Example: https://jsfiddle.net/wxekqcnp/2/

Do I misunderstand the intended behavior, or is this a bug?
harttle added a commit that referenced this issue Jul 22, 2019
@harttle
fix: some filters on undefined variable throws, #140
5c78eac
harttle added a commit that referenced this issue Jul 22, 2019
@harttle
fix: some filters on undefined variable throws, #140
6e6ea0a
@harttle harttle added the bug label Jul 22, 2019
@harttle harttle self-assigned this Jul 22, 2019
harttle pushed a commit that referenced this issue Jul 22, 2019
@semantic-release-bot
chore(release): 8.4.1 [skip ci]
49c45a4 
## [8.4.1](v8.4.0...v8.4.1) (2019-07-22)

### Bug Fixes

* some filters on undefined variable throws, [#140](#140) ([6e6ea0a](6e6ea0a))
@harttle harttle closed this as completed Jul 22, 2019
@snyk-bot snyk-bot mentioned this issue Apr 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harttle harttle

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinbijlani @harttle