Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ES6 for ESM bundle #526

Closed
binyamin opened this issue Aug 1, 2022 · 1 comment
Closed

Target ES6 for ESM bundle #526

binyamin opened this issue Aug 1, 2022 · 1 comment

Comments

@binyamin
Copy link

binyamin commented Aug 1, 2022

Summary

The ESM bundle still targets ES5, which was released in 2009. As far as I can tell, ESM itself was introduced in 2015, so the bundle should really target ES6.

compilerOptions: {
target: 'es5',

Use-case

Currently, class "extends" are polyfilled. This means that all of liquid's custom error classes show up as basic Error objects, instead of ParseError etc. The effect is, that it's not easy to use instanceof to check if it's a liquid class.

github-actions bot pushed a commit that referenced this issue Aug 14, 2022
# [9.40.0](v9.39.2...v9.40.0) (2022-08-14)

### Bug Fixes

* target ES6 for ESM bundles, fixes [#526](#526) ([905a6dd](905a6dd))

### Features

* export toValueSync & defaultOptions to evaluate expression, see [#527](#527) ([e874b40](e874b40))
@github-actions
Copy link

🎉 This issue has been resolved in version 9.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants