Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line/col in Error message not precise #613

Closed
harttle opened this issue May 23, 2023 · 0 comments
Closed

line/col in Error message not precise #613

harttle opened this issue May 23, 2023 · 0 comments
Labels
bug

Comments

@harttle
Copy link
Owner

harttle commented May 23, 2023

For example this one:

>> 1| {{ "a": b }}
ParseError: expected "|" before filter, line:1, col:1

Should be

>> 1| {{ "a": b }}
ParseError: expected "|" before filter, line:1, col:7
@harttle harttle added the bug label May 23, 2023
harttle added a commit that referenced this issue May 24, 2023
@harttle
fix: more precise line/col for parse Error message, #613
1039a31
harttle added a commit that referenced this issue May 29, 2023
@harttle
fix: more precise line/col for parse Error message, #613
63d3039
harttle added a commit that referenced this issue Jun 1, 2023
@harttle
feat: precise line/col for tokenization Error, #613
f038681
harttle added a commit that referenced this issue Jun 3, 2023
@harttle
feat: precise line/col for tokenization Error, #613
ec8de0b
harttle added a commit that referenced this issue Jun 3, 2023
@harttle
feat: precise line/col for tokenization Error, #613
74ba0e7
harttle added a commit that referenced this issue Jun 3, 2023
@harttle
feat: precise line/col for tokenization Error, #613
0564126
harttle added a commit that referenced this issue Jun 3, 2023
@harttle
feat: precise line/col for tokenization Error, #613
e347e60
github-actions bot pushed a commit that referenced this issue Jun 3, 2023
@semantic-release-bot
chore(release): 10.8.0 [skip ci]
87e83b6 
# [10.8.0](v10.7.1...v10.8.0) (2023-06-03)

### Bug Fixes

* proper error message for filter syntax error, [#610](#610) ([0480d33](0480d33))
* sed invocations to work out of the box on macOS ([#615](#615)) ([87d4cc7](87d4cc7))

### Features

* Add support for the Jekyll sample filter ([#612](#612)) ([ba8b842](ba8b842))
* introduce a matrix with latest Ubuntu and macOS to test the build on macOS as well ([82ba548](82ba548)), closes [#615](#615)
* precise line/col for tokenization Error, [#613](#613) ([e347e60](e347e60))
@harttle harttle closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harttle