Add explicit braced property access parsing #260
Conversation
| this.readTo(']') | ||
| return new PropertyAccessToken(prop, [], this.p) | ||
| } | ||
|
|
There was a problem hiding this comment.
How about ["foo"]["bar"] or ["foo"].bar?
We need adapt the following logic (the PropertyAccessToken part) to support this case (remove the variable constructor argument and make it the first props maybe?).
There was a problem hiding this comment.
Makes sense, although the number of potential valid syntaxes are getting a bit scary. Do you think that could be postponed into the future and this feature shipped as is (once I fix the tests passing)?
There was a problem hiding this comment.
the number of potential valid syntaxes are getting a bit scary
Seems it can be done by consume the [, call readValue recursively(as in props brackets), and consume the ]. This way the following cases will be supported also:
{{["foo"].bar}}
{{[0].bar}}
{{[key].bar}}
|
🎉 This PR is included in version 9.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Parses braced property accesses similar to how Ruby Liquid does it. Fixes #259