Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust typings dir #664

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

fupengl
Copy link

@fupengl fupengl commented Jan 12, 2024

Adjust the compatible typing file path to keep it consistent with historical versions.

Now

import { Tag } from 'liquidjs/dist/src/tags/assign'

Old

import { Tag } from 'liquidjs/dist/tags/assign'

@harttle
Copy link
Owner

harttle commented Jan 12, 2024

Do we have real world scenarios where it's broken from some version? So we can change this patch from a chore to a fix. Otherwise we will not release the change until next fix or feature.

I think this change is good to have to reduce unnecessary hierarchy. Thanks for the change.

@harttle harttle merged commit 3632623 into harttle:master Jan 14, 2024
12 checks passed
@harttle
Copy link
Owner

harttle commented Jan 14, 2024

@all-contributors please add @fupengl for code.

Copy link
Contributor

@harttle

I've put up a pull request to add @fupengl! 🎉

@fupengl
Copy link
Author

fupengl commented Jan 14, 2024

Do we have real world scenarios where it's broken from some version? So we can change this patch from a chore to a fix. Otherwise we will not release the change until next fix or feature.

I think this change is good to have to reduce unnecessary hierarchy. Thanks for the change.

The version I used before was 10.6.1. After upgrading to the latest version, an error occurred in the ts type.

@fupengl fupengl deleted the fix/typings-root branch January 15, 2024 03:10
Copy link

🎉 This PR is included in version 10.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants