Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow lenientIf for multiple operands (issue #682) #683

Merged
merged 2 commits into from Apr 21, 2024

Conversation

amedve
Copy link
Contributor

@amedve amedve commented Apr 17, 2024

Closes #682

@amedve amedve changed the title Allow lenientIf for multiple operands (issue #682) feat: Allow lenientIf for multiple operands (issue #682) Apr 17, 2024
@harttle harttle changed the title feat: Allow lenientIf for multiple operands (issue #682) fix: Allow lenientIf for multiple operands (issue #682) Apr 21, 2024
@harttle harttle merged commit 490ff43 into harttle:master Apr 21, 2024
13 of 14 checks passed
@harttle
Copy link
Owner

harttle commented Apr 21, 2024

I think it makes sense to loosen the check when lenientIf is specified, as it's still within an if tag. And I believe this change will not break things, as we're loosening it instead of tightening.

@harttle
Copy link
Owner

harttle commented Apr 21, 2024

@all-contributors please add amedve for code.

Copy link
Contributor

@harttle

I've put up a pull request to add @amedve! 🎉

github-actions bot pushed a commit that referenced this pull request Apr 21, 2024
## [10.11.1](v10.11.0...v10.11.1) (2024-04-21)

### Bug Fixes

* allow %Z for TimezoneDate, update docs accordingly [#684](#684) ([e09657c](e09657c))
* Allow `lenientIf` for multiple operands (issue [#682](#682)) ([#683](#683)) ([490ff43](490ff43))
Copy link

🎉 This PR is included in version 10.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow lenientIf for multiple operands
2 participants